From 0d8371e3df38feb7e8d2da7b116c2510233c64ef Mon Sep 17 00:00:00 2001
From: asif <md.asif5@tcs.com>
Date: Wed, 10 Sep 2025 16:12:46 +0530
Subject: [PATCH] added ifsc code validation for internal transfers

---
 src/services/beneficiary.service.js | 15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

diff --git a/src/services/beneficiary.service.js b/src/services/beneficiary.service.js
index 1eeb7d1..5d5cca7 100644
--- a/src/services/beneficiary.service.js
+++ b/src/services/beneficiary.service.js
@@ -56,17 +56,22 @@ async function deleteBeneficiary(customerNo, beneficiaryAccountNo) {
 
 async function getAllBeneficiaries(customerNo) {
   const queryStr =
-    'SELECT b.account_no, b.name, b.account_type, b.ifsc_code, i.bank_name, i.branch_name FROM beneficiaries b JOIN ifsc_details i ON b.ifsc_code = i.ifsc_code WHERE customer_no = $1';
+    'SELECT b.account_no, b.name, b.account_type, b.ifsc_code, i.bank_name, i.branch_name FROM beneficiaries b JOIN LATERAL( SELECT * FROM ifsc_details i WHERE i.ifsc_code = b.ifsc_code LIMIT 1 ) i ON true WHERE customer_no = $1';
   const result = await db.query(queryStr, [customerNo]);
   const list = result.rows.map((row) => {
-    return {
+    const details = {
       accountNo: row['account_no'],
       name: row['name'],
       accountType: row['account_type'],
-      ifscCode: row['ifsc_code'],
-      bankName: row['bank_name'],
-      branchName: row['branch_name'],
     };
+    if (row['ifsc_code'] === '_') {
+      details['bankName'] = 'THE KANGRA CENTRAL COOPERATIVE BANK LIMITED';
+    } else {
+      details['ifscCode'] = row['ifsc_code'];
+      details['bankName'] = row['bank_name'];
+      details['branchName'] = row['branch_name'];
+    }
+    return details;
   });
 
   return list;